Hello Marek,
Am 01.05.2018 um 09:03 schrieb Marek Vasut:
Add derivative of the rcar_i2c driver which is capable of
probing itself from DM and uses DT.
Signed-off-by: Marek Vasut <marek.vasut+rene...@gmail.com>
Cc: Heiko Schocher <h...@denx.de>
Cc: Nobuhiro Iwamatsu <iwama...@nigauri.org>
---
drivers/i2c/Kconfig | 6 +
drivers/i2c/Makefile | 1 +
drivers/i2c/rcar_i2c.c | 355 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 362 insertions(+)
create mode 100644 drivers/i2c/rcar_i2c.c
I fixed patch 1/4 and tried to apply this patch, but checkpatch says:
--2018-05-10 09:16:48-- http://patchwork.ozlabs.org/patch/906952/mbox
Auflösen des Hostnamens patchwork.ozlabs.org (patchwork.ozlabs.org)…
203.11.71.1, 2401:3900:2:1::2
Verbindungsaufbau zu patchwork.ozlabs.org
(patchwork.ozlabs.org)|203.11.71.1|:80 … verbunden.
HTTP-Anforderung gesendet, auf Antwort wird gewartet … 301 Moved Permanently
Platz: /patch/906952/mbox/ [folgend]
--2018-05-10 09:16:49-- http://patchwork.ozlabs.org/patch/906952/mbox/
Wiederverwendung der bestehenden Verbindung zu patchwork.ozlabs.org:80.
HTTP-Anforderung gesendet, auf Antwort wird gewartet … 200 OK
Länge: nicht spezifiziert [text/plain]
Wird in »mbox« gespeichert.
mbox [ <=>
] 11,38K --.-KB/s in 0,01s
2018-05-10 09:16:50 (933 KB/s) - »mbox« gespeichert [11653]
WARNING: please write a paragraph that describes the config symbol fully
#37: FILE: drivers/i2c/Kconfig:342:
+config SYS_I2C_RCAR_I2C
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#59:
new file mode 100644
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
#64: FILE: drivers/i2c/rcar_i2c.c:1:
+/*
CHECK: Blank lines aren't necessary after an open brace '{'
#214: FILE: drivers/i2c/rcar_i2c.c:151:
+ for (i = 0; i < msg->len; i++) {
+
total: 0 errors, 3 warnings, 1 checks, 374 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
mbox has style problems, please review.
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
NETWORKING_BLOCK_COMMENT_STYLE PREFER_ETHER_ADDR_COPY USLEEP_RANGE
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Wende an: i2c: rcar_i2c: Add DM and DT capable I2C driver
Coukd you please send a rebased version of the patchset?
Thanks!
Beside of this, you can add my to patch 1 and 2:
Reviewed-by: Heiko Schocher <h...@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: h...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
