On 22 May 2018 at 18:53, Alex Kiernan <alex.kier...@gmail.com> wrote: > On Tue, May 22, 2018 at 4:29 PM Sam Protsenko <semen.protse...@linaro.org> > wrote: > >> On 22 May 2018 at 18:21, Sam Protsenko <semen.protse...@linaro.org> wrote: >> > On 22 May 2018 at 12:23, Alex Kiernan <alex.kier...@gmail.com> wrote: >> >> Convert USB fastboot code to use shared fastboot protocol. >> >> >> >> Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> >> >> --- >> >> >> >> Changes in v6: >> >> - merged from RFC USB fastboot series >> >> - when entering the DATA phase ensure we actually install the correct > handler >> >> - on completion of DATA call new fastboot_data_complete() >> >> - previous changes: >> >> - remove redundant version.h >> >> - use new fastboot_get_bytes_remaining() function >> > >> > Hi Alex, >> > >> > I tested this new patch series (v6) on X15 board, and this patch still >> > breaks "fastboot oem format". I see next messages. >> > >> > On host: >> > >> > FAILED (remote: unrecognized command) >> > >> > On device: >> > >> > command oem format not recognized. >> > >> > All other fastboot commands seem to work fine, though. Can you please >> > look into it? I can help you with testing on my boards, if you are >> > unable to reproduce it. You can prepare GitHub branch for debugging >> > and ask me to check that, I will send you the output. >> > >> > Thanks. > >> Btw, I looked in my .config, and I see that: > >> # CONFIG_FASTBOOT_CMD_OEM_FORMAT is not set > >> What I think should be done, is in your patch: > >> fastboot: Add support for 'oem format' command > >> make default=y for FASTBOOT_CMD_OEM_FORMAT. Or add that to all boards >> that use "fastboot oem format". Not sure what is proper way here, but >> defaulting it to "n" (like it's done now) might break a lot of boards. > > Oh bother... and thank you for testing (again). > > I guess if we enable it on all boards that currently select USB fastboot as > part of the patch that merges USB and UDP, then we'll get all existing > boards and don't end up with a default y? >
As I see it, the only correct approach in this case is to keep it as it was before. So basically all configs that defined FASTBOOT_FLASH_MMC_DEV option (explicitly or implicitly), should also have FASTBOOT_CMD_OEM_FORMAT enabled. > -- > Alex Kiernan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
