Hi Mario, On 23 May 2018 at 06:09, Mario Six <mario....@gdsys.cc> wrote: > Add a driver for IHS OSDs on IHS FPGAs. > > Signed-off-by: Mario Six <mario....@gdsys.cc> > > --- > > v1 -> v2: > * Renamed x and y parameters to col and row > * Removed duplicate IHS_VIDEO_OUT definition > * Switched error return code of ihs_video_out_set_mem to E2BIG > * Dropped blank lines between dev_read_u32_default calls > * Documented members of ihs_video_out_priv > * Turned printfs into debugs > * Don't display OSD until something has been written to it > * Made the code a bit more readable > * Added binding file > * Expanded documentation and help > * Switched to display_enable > * Switched to regmap usage (instead of fpgamap uclass) > * Renamed 'dp_tx' property to 'video_tx' > > --- > .../video/osd/gdsys,ihs_video_out.txt | 22 ++ > drivers/video/Kconfig | 9 + > drivers/video/Makefile | 1 + > drivers/video/ihs_video_out.c | 277 > +++++++++++++++++++++ > 4 files changed, 309 insertions(+) > create mode 100644 doc/device-tree-bindings/video/osd/gdsys,ihs_video_out.txt > create mode 100644 drivers/video/ihs_video_out.c >
Reviewed-by: Simon Glass <s...@chromium.org> You could perhaps s/dev_read_prop/dev_read_string/ to avoid the cast. Also is there a binding file for your driver's device-tree node somewhere? Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
