On Fri, May 25, 2018 at 3:42 AM Simon Glass <s...@chromium.org> wrote:
> Hi Alex, > On 24 May 2018 at 07:29, Alex Kiernan <alex.kier...@gmail.com> wrote: > > > > Introduce CONFIG_IMAGE_SPARSE and CONFIG_CMD_MMC_SWRITE so the "mmc > > swrite" command is separated from the fastboot code. > > > > Move image-sparse from common to lib so it's clear it's library code. > > > > Rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE > > and migrate it to Kconfig. > > > > Signed-off-by: Alex Kiernan <alex.kier...@gmail.com> > > Acked-by: Jassi Brar <jaswinder.si...@linaro.org> > > --- > > > > Changes in v7: None > > Changes in v6: None > > Changes in v5: > > - rename CONFIG_FASTBOOT_FLASH_FILLBUF_SIZE to CONFIG_IMAGE_SPARSE_FILLBUF_SIZE > > and migrate it to Kconfig. > > > > Changes in v4: > > - new > > > > Changes in v3: None > > Changes in v2: None > > > > cmd/Kconfig | 8 ++++++++ > > cmd/mmc.c | 12 ++++++------ > > common/Makefile | 1 - > > drivers/fastboot/Kconfig | 1 + > > lib/Kconfig | 11 +++++++++++ > > lib/Makefile | 1 + > > {common => lib}/image-sparse.c | 6 +----- > > scripts/config_whitelist.txt | 1 - > > 8 files changed, 28 insertions(+), 13 deletions(-) > > rename {common => lib}/image-sparse.c (97%) > Reviewed-by: Simon Glass <s...@chromium.org> > I'm not 100% sure about moving image-sparce to lib/ but I suppose it is OK. My reasoning was it's really a compression mechanism, and thats where we have the other compression stuff (I should probably have written this in the commit message). -- Alex Kiernan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot