On Fri, May 25, 2018 at 10:45:53AM +0800, Ley Foon Tan wrote: > On Thu, May 24, 2018 at 8:39 PM, Tom Rini <tr...@konsulko.com> wrote: > > On Tue, May 08, 2018 at 11:19:24AM +0800, Ley Foon Tan wrote: > > > >> Add code to reset all reset signals as in mmc DT node. A reset property is > >> an optional feature, > >> so only print out a warning and do not fail if a reset property is not > >> present. > >> > >> If a reset property is discovered, then use it to deassert, thus bringing > >> the > >> IP out of reset. > >> > >> Signed-off-by: Ley Foon Tan <ley.foon....@intel.com> > >> Reviewed-by: Simon Glass <s...@chromium.org> > >> --- > >> drivers/mmc/socfpga_dw_mmc.c | 17 +++++++++++++++++ > >> 1 files changed, 17 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c > >> index fa0e449..eb7e64e 100644 > >> --- a/drivers/mmc/socfpga_dw_mmc.c > >> +++ b/drivers/mmc/socfpga_dw_mmc.c > >> @@ -13,6 +13,7 @@ > >> #include <linux/libfdt.h> > >> #include <linux/err.h> > >> #include <malloc.h> > >> +#include <reset.h> > >> > >> DECLARE_GLOBAL_DATA_PTR; > >> > >> @@ -33,6 +34,20 @@ struct dwmci_socfpga_priv_data { > >> unsigned int smplsel; > >> }; > >> > >> +static void socfpga_dwmci_reset(struct udevice *dev) > >> +{ > >> + struct reset_ctl_bulk reset_bulk; > >> + int ret; > >> + > >> + ret = reset_get_bulk(dev, &reset_bulk); > >> + if (ret) { > >> + dev_warn(dev, "Can't get reset: %d\n", ret); > >> + return; > >> + } > >> + > >> + reset_deassert_bulk(&reset_bulk); > >> +} > > > > The driver doesn't depend on DM_RESET and this code hunk doesn't either > > so it fails to build on a number of platforms. This type of comment > > applies to the whole series, and may be fixed differently in different > > cases (it might be OK to enforce DM_RESET for this driver, but not for > > the ns16550 driver). > > > > -- > > Tom > > > include/reset.h has the DM_RESET wrapper, so it will not cause the > compilation error if the CONFIG_DM_RESET is disabled. > > I have tried compile the uboot with CONFIG_DM_RESET disabled, > compilation is fine.
This whole series causes a good percent of the world to fail to link, so something is off about the wrappers or use of them. See: https://travis-ci.org/trini/u-boot/jobs/382783645 -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot