On 06/01/2018 10:52 AM, Ley Foon Tan wrote:
> Use "%lu" for size_t data type.
>
> Compilation warning as below:
>
> In file included from include/linux/bug.h:7:0,
> from include/common.h:26,
> from drivers/spi/cadence_qspi.c:8:
> drivers/spi/cadence_qspi.c: In function ‘cadence_spi_xfer’:
> drivers/spi/cadence_qspi.c:211:8: warning: format ‘%d’ expects argument of
> type ‘int’, but argument 3 has type ‘size_t {aka long unsigned int}’
> [-Wformat=]
> debug("%s: len=%d [bytes]\n", __func__, data_bytes);
> ^
> include/linux/printk.h:37:21: note: in definition of macro ‘pr_fmt’
> #define pr_fmt(fmt) fmt
> ^~~
> include/log.h:142:2: note: in expansion of macro ‘debug_cond’
> debug_cond(_DEBUG, fmt, ##args)
> ^~~~~~~~~~
> drivers/spi/cadence_qspi.c:211:2: note: in expansion of macro ‘debug’
> debug("%s: len=%d [bytes]\n", __func__, data_bytes);
>
> Signed-off-by: Ley Foon Tan <ley.foon....@intel.com>
Acked-by: Marek Vasut <ma...@denx.de>
btw missing [PATCH v2 2/2] in the SUBJECT ...
> ---
> v2: use "%lu" instead of cast data type to ulong.
> ---
> drivers/spi/cadence_qspi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/cadence_qspi.c b/drivers/spi/cadence_qspi.c
> index 91742ba..63249c5 100644
> --- a/drivers/spi/cadence_qspi.c
> +++ b/drivers/spi/cadence_qspi.c
> @@ -207,7 +207,7 @@ static int cadence_spi_xfer(struct udevice *dev, unsigned
> int bitlen,
> } else {
> data_bytes = bitlen / 8;
> }
> - debug("%s: len=%d [bytes]\n", __func__, data_bytes);
> + debug("%s: len=%lu [bytes]\n", __func__, data_bytes);
>
> /* Set Chip select */
> cadence_qspi_apb_chipselect(base, spi_chip_select(dev),
>
--
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
