Hi, On 14 June 2018 at 11:25, Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> wrote: > Hi Simon, > > On Thu, Jun 14, 2018 at 08:16:53AM -0600, Simon Glass wrote: >> Hi, >> >> On 14 June 2018 at 07:13, Manivannan Sadhasivam >> <manivannan.sadhasi...@linaro.org> wrote: >> > Hi Simon, >> > >> > On Thu, Jun 14, 2018 at 06:58:40AM -0600, Simon Glass wrote: >> >> Hi, >> >> >> >> On 12 June 2018 at 22:15, Manivannan Sadhasivam >> >> <manivannan.sadhasi...@linaro.org> wrote: >> >> > This commit adds Actions Semi OWL family base clock and S900 SoC >> >> > specific >> >> > clock support. For S900 peripheral clock support, only UART clock has >> >> > been >> >> > added for now. >> >> > >> >> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org> >> >> > --- >> >> > arch/arm/include/asm/arch-owl/clk_s900.h | 57 +++++++++ >> >> > arch/arm/include/asm/arch-owl/regs_s900.h | 64 ++++++++++ >> >> > drivers/clk/Kconfig | 1 + >> >> > drivers/clk/Makefile | 1 + >> >> > drivers/clk/owl/Kconfig | 12 ++ >> >> > drivers/clk/owl/Makefile | 3 + >> >> > drivers/clk/owl/clk_s900.c | 138 ++++++++++++++++++++++ >> >> > 7 files changed, 276 insertions(+) >> >> > create mode 100644 arch/arm/include/asm/arch-owl/clk_s900.h >> >> > create mode 100644 arch/arm/include/asm/arch-owl/regs_s900.h >> >> > create mode 100644 drivers/clk/owl/Kconfig >> >> > create mode 100644 drivers/clk/owl/Makefile >> >> > create mode 100644 drivers/clk/owl/clk_s900.c >> >> >> >> This says v2 but I don't see a change log. Have you tried using >> >> patman? It does this for you easily. >> >> >> > >> > Sorry, I have added the changelog in coverletter of the patchseries! Is it >> > a >> > bad practice in U-Boot? >> >> I'm not sure about bad practice, but without it, it's hard to know >> what you've changed in this patch. >> > > Okay. Should I send another version adding changelog in commit?
That would make me happy :-) Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
