Hi Simon, On Mon, Jul 9, 2018 at 10:39 AM, Simon Glass <s...@chromium.org> wrote: > Hi Bin, > > On 3 July 2018 at 02:48, Bin Meng <bmeng...@gmail.com> wrote: >> In preparation for the reset driver conversion, eliminate the >> reset_cpu() call in the FSP init path as it's too early for the >> reset driver to work. >> >> Signed-off-by: Bin Meng <bmeng...@gmail.com> >> --- >> >> arch/x86/lib/fsp/fsp_common.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <s...@chromium.org> > > But it would be good to have a comment explaining this in the code.
There is already a comment /* Reboot */ before the debug() call. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
