On Tue, Aug 07, 2018 at 12:18:04PM +0200, Stefan Roese wrote: > On 06.08.2018 20:52, Tom Rini wrote: > >On Mon, Aug 06, 2018 at 05:13:44PM +0200, Stefan Roese wrote: > > > >>Commit 6a3e65dea3e5 ("common: Drop LOGLEVEL to 4") reduced the loglevel > >>resulting in pr_warn() messages fro e.g. UBI are not shown anymore. With > >>this change back to 6, messages like this appear again: > >> > >>nand: attempt to erase a bad/reserved block @6000000 > >> > >>Signed-off-by: Stefan Roese <s...@denx.de> > >>Cc: Tom Rini <tr...@konsulko.com> > >>--- > >> common/Kconfig | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/common/Kconfig b/common/Kconfig > >>index 4d7215a360..678a108508 100644 > >>--- a/common/Kconfig > >>+++ b/common/Kconfig > >>@@ -266,7 +266,7 @@ config IDENT_STRING > >> config LOGLEVEL > >> int "loglevel" > >>- default 4 > >>+ default 6 > >> range 0 8 > >> help > >> All Messages with a loglevel smaller than the console loglevel will > > > >This is a huge size increase on boards that rely on the default. And I > >bet this causes some boards to no longer link. That said, if boards > >want more logging messages, such as warnings, they can increase it on > >their own. If you feel that whole SoCs would benefit from this, I have > >no objection to default 6 if ... being added. And if the example > >message you gave is more than just a warning and should be seen more > >often, perhaps it should be a higher level message? Thanks! > > Its a "warn" and this should be visible to the user IMHO. One might > discuss, if an "info" or "notice" text should printed, but warnings > seem quite important (at least for my taste). Changing this to even > higher level messages (like "err") is too much. And this would lead > to differences between Linux and U-Boot which we should avoid. > > Back to the issue, if you don't want to pull this change for the > default LOGLEVEL, I will change it for this board or platform as you > suggested above. Just let me know.
Please bump it per board/SoC, thanks! -- Tom
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot