Hi Nick,
> I didn't check, but I would assume checkpatch would complain about the
> spaces that have crept in here?
Interestingly checkpatch complains only if it finds 8 or more spaces at the
beginning of the line (below). For some reason, vim cindent inserted 7 spaces
in there, and that kept checkpatch from complaining.
...
# at the beginning of a line any tabs must come first and anything
# more than 8 must use tabs.
if ($rawline =~ /^\+\s* \t\s*\S/ ||
$rawline =~ /^\+\s* \s*/) {
my $herevet = "$here\n" . cat_vet($rawline) . "\n";
ERROR("code indent should use tabs where possible\n" .
$herevet);
}
...
> If you haven't already done so, it would be a good idea to run
> checkpatch to check for any other formatting violations.
Thanks, resubmitted.
Regards
Cyril.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
