On 08/15/2018 04:30 PM, Tom Rini wrote: > On Wed, Aug 08, 2018 at 01:20:29PM +0200, Marek Vasut wrote: > >> Cache up to 4 kiB entries. 4 kiB is the default block size on ext4, yet >> the underlying block layer devices usually report support for 512B . In >> most cases, the 512B support is emulated (ie. SD cards, SSDs, USB sticks >> etc.) and the real block size of those devices is much bigger. >> >> To avoid performance degradation with such devices and FS setup, bump >> the maximum cache entry size to 4 kiB. >> >> Signed-off-by: Marek Vasut <ma...@denx.de> >> Cc: Tom Rini <tr...@konsulko.com> >> Cc: Simon Glass <s...@chromium.org> > > Reviewed-by: Tom Rini <tr...@konsulko.com> > > I'll pick this up post v2018.09 if no one objects, thanks!
I object. I was hoping there'd be some discussion on how to solve this in a future-proof manner ... it's only a matter of time until someone uses ext4 with 8k blocks on an SSD ... -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot