Hi, On 18 September 2018 at 02:08, Liviu Dudau <liviu.du...@foss.arm.com> wrote: > > On Tue, Sep 18, 2018 at 04:06:13AM +0200, Simon Glass wrote: > > On 17 September 2018 at 10:44, Liviu Dudau <liviu.du...@foss.arm.com> wrote: > > > Use the uclass_foreach_dev() macro instead of the open coded version. > > > > > > Signed-off-by: Liviu Dudau <liviu.du...@foss.arm.com> > > > --- > > > drivers/core/uclass.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > Perhaps you could also convert a few usages? > > Not sure what you mean. Are you suggesting that I should convert more of > the code that uses the open coded version into uclass_foreach_dev() ?
Yes. After all, at present your macro is just dead code :-) Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot