On Tue, 2018-10-02 at 15:07 +0200, Matthias Brugger wrote: > I'm very happy to see Mediatek working on mainline u-boot support! > > On 02/10/2018 08:13, Ryder Lee wrote: > > This patch adds mt7629.dtsi and reference board support. > I think reference board support is already added in 2/20. > AFAICS you just device tree and the includes it needs. > > > > > Signed-off-by: Ryder Lee <ryder....@mediatek.com> > > --- > > arch/arm/dts/Makefile | 3 + > > arch/arm/dts/mt7629-rfb.dts | 71 ++++++++++ > > arch/arm/dts/mt7629.dtsi | 232 > > +++++++++++++++++++++++++++++++ > > include/configs/mt7629.h | 2 + > > include/dt-bindings/clock/mt7629-clk.h | 217 > > +++++++++++++++++++++++++++++ > > include/dt-bindings/power/mt7629-power.h | 13 ++ > > 6 files changed, 538 insertions(+) > > create mode 100644 arch/arm/dts/mt7629-rfb.dts > > create mode 100644 arch/arm/dts/mt7629.dtsi > > create mode 100644 include/dt-bindings/clock/mt7629-clk.h > > create mode 100644 include/dt-bindings/power/mt7629-power.h > > > [...] > > + > > + watchdog: watchdog@10212000 { > > + compatible = "mediatek,wdt"; > > Will this be passed to the kernel later?
No, I didn't pass dtb in my tests. I just let them independent. > If so, you should add a upstream-like compatible (at least). > BTW none of the mt7629 compatible is upstream in the kernel. Not sure if > that's > an issue for u-boot, TBH. I'm not sure either. If we decide to pass the U-boot dtb to kernel I will modify the string in v1. A related question is that we rely on the fallback compatible "mediatek,mt6577-*" for timer, wdt, and other common IPs, but obviously, we didn't have MT6577 support in U-boot. That's why I pick a generic name for timer and WDT. Also, I directly use "ns16500a" as compatible for uart in U-boot. Moreover, I think/guess the DTS is hard to share with kernel as there are many properties don't support in U-boot stage. Ryder > > + reg = <0x10212000 0x600>; > > + interrupts = <GIC_SPI 128 IRQ_TYPE_EDGE_FALLING>; > > + #reset-cells = <1>; > > + status = "disabled"; > > + }; > > + > > + wdt-reboot { > > + compatible = "wdt-reboot"; > > + wdt = <&watchdog>; > > + }; > > + > > Regards, > Matthias _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot