Hello,
On Mon, 8 Oct 2018 19:46:27 +0200, Boris Brezillon wrote:
> > + /* Check if mtdparts/mtdids changed since last call, otherwise: exit */
> > + if (!strcmp(mtdparts, old_mtdparts) && !strcmp(mtdids, old_mtdids))
> > + return 0;
>
> Should be:
>
> if ((!mtdparts && !old_mtdparts && !mtdids && !old_mtdids) ||
If there's a || here, it means you can split the conditions into to:
if (!mtdparts && !old_mtdparts && !mtdids && !old_mtdids)
return 0;
if (mtdparts && old_mtdparts && mtdids && old_mtdids &&
!strcmp(mtdparts, old_mtdparts) &&
!strcmp(mtdids, old_mtdids)))
return 0;
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
