Alexander Holler wrote: > Am 03.04.2010 20:33, schrieb Tom: >> Alexander Holler wrote: >> >> Change parameter name to something more descriptive. >> 'tmp' implies used locally and this value is passed back. >> Maybe 'tm' as to_tmp(.., struct rtc_time *tm) ? >> > > Maybe someone should place a README in drivers/rtc which reads "Don't > use this stuff as template" as almost every source there uses this tmp. >
The important change for this patch is to move to the new Soc access. The other uses of rtc_time *tmp, I would also consider as problems. Changing tmp -> tm for your patch is an improvement. This is good time to make it. Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot