On Fri, 16 Nov 2018 15:40:25 +0100 Boris Brezillon <boris.brezil...@bootlin.com> wrote:
> If we don't do that, partitions might still be exposed while the > underlying device is gone. > > Fixes: 2a74930da57f ("mtd: mtdpart: implement proper partition handling") > Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> > --- > drivers/mtd/mtdcore.c | 1 + > include/linux/mtd/mtd.h | 14 ++++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index 7a15ded8c883..46657fe7c949 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -528,6 +528,7 @@ int del_mtd_device(struct mtd_info *mtd) > struct mtd_notifier *not; > #endif > > + del_mtd_partitions(mtd); > mutex_lock(&mtd_table_mutex); > > if (idr_find(&mtd_idr, mtd->index) != mtd) { > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h > index d20ebd820289..c5b58dd3f0f7 100644 > --- a/include/linux/mtd/mtd.h > +++ b/include/linux/mtd/mtd.h > @@ -562,8 +562,22 @@ unsigned mtd_mmap_capabilities(struct mtd_info *mtd); > /* drivers/mtd/mtdcore.h */ > int add_mtd_device(struct mtd_info *mtd); > int del_mtd_device(struct mtd_info *mtd); > + > +#ifdef CONFIG_MTD_PARTITIONS > int add_mtd_partitions(struct mtd_info *, const struct mtd_partition *, int); > int del_mtd_partitions(struct mtd_info *); > +#else > +static inline int add_mtd_partitions(struct mtd_info *, > + const struct mtd_partition *, int) Args should have names. > +{ > + return 0; > +} > + > +static int del_mtd_partitions(struct mtd_info *) Missing inline here. I'll send a v2 fixing those 2 bugs. > +{ > + return 0; > +} > +#endif > > struct mtd_info *__mtd_next_device(int i); > #define mtd_for_each_device(mtd) \ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot