> On 03.01.2019, at 22:29, Simon Glass <s...@chromium.org> wrote:
>
> Hi,
>
> On Thu, 3 Jan 2019 at 00:32, Kever Yang <kever.y...@rock-chips.com
> <mailto:kever.y...@rock-chips.com>> wrote:
>>
>> Hi Simon,
>>
>>
>> On 12/29/2018 09:16 PM, Simon Glass wrote:
>>> This function causes a 5-second delay and stops the display working on
>>> minnie.
>>
>> I don't understand why need 5-second, the logic is to check the adc key
>> press to decide the mode, maybe because the different usage of the adc
>> in minnie?
>>
>> Most of boards(which do not have ec like chromebook) need this check to
>> get into download mode.
>> I would prefer chrombook to implement a function to replace the week
>> rockchip_dnl_mode_check();
>
> But where is it specified in the DT that it uses the ADC for this
> feature? It really should have a driver…
3 things:
a. It really should have a driver.
b. One does not have to replace rockchip_dnl_mode_check(), as there
already is logic to remove it if CONFIG_ROCKCHIP_BOOT_MODE_REG
is set to 0 in the config.
c. We really need to get away from configuring magic addresses via
Kconfig.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
