On Fri, Jan 18, 2019 at 08:57:43AM +1300, Chris Packham wrote:
> Hi Stefan,
> 
> On Fri, Jan 18, 2019 at 2:35 AM Stefan Roese <s...@denx.de> wrote:
> >
> > This patch enables the DT PCIe nodes for the Armada XP/37x/38x boards.
> > This is needed for the new DM_PCI support in the MVEBU PCIe driver.
> >
> > Signed-off-by: Stefan Roese <s...@denx.de>
> > Cc: Dirk Eibach <dirk.eib...@gdsys.cc>
> > Cc: Mario Six <mario....@gdsys.cc>
> > Cc: Chris Packham <chris.pack...@alliedtelesis.co.nz>
> > Cc: Phil Sutter <p...@nwl.cc>
> > Cc: Marek BehĂșn <marek.be...@nic.cz>
> > Cc: VlaoMao <vlao...@gmail.com>
> > ---
> >  arch/arm/dts/armada-375.dtsi        | 2 +-
> >  arch/arm/dts/armada-380.dtsi        | 2 +-
> >  arch/arm/dts/armada-385.dtsi        | 2 +-
> >  arch/arm/dts/armada-xp-mv78230.dtsi | 2 +-
> >  arch/arm/dts/armada-xp-mv78260.dtsi | 2 +-
> >  arch/arm/dts/armada-xp-mv78460.dtsi | 2 +-
> >  6 files changed, 6 insertions(+), 6 deletions(-)
> 
> I think this should be at the board level instead of the SoC. There
> are boards that don't use the pcie controller even though it's in the
> SoC. Another good reason is that this deviates from the dtsi files in
> Linux
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/armada-375.dtsi#n548

Yes, we should keep these files in-sync with Linux and use -u-boot.dtsi
files (see scripts/Makefile.lib for the search logic) to change / add
properties as needed.

-- 
Tom

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to