Kever, Independent of whether we revert this for the current cycle (and also independent of if I ever find the other patch you had been referring to — I couldn’t find it in my local mailing list archive) and then deprecate it for the next release (unless converted to DM), we still have a number of architectural issues that need to be addressed: 1. This really should be a driver under DTS control. 2. We need to not get away from configuring SOM-specific addresses via Kconfig
Both these issues are technical debt that we’ve accumulated over the last 18 months and need to address for the sake of future maintainability. E.g. ‘setting an address to 0x0 via Kconfig to disable a driver/feature’ really isn’t in line with the architectural direction of U-Boot. I don’t have my own house completely in order (I’ve been talking for a year now about finally wrapping the RGMII/GMII selection into an ioctl-call to a driver) yet, but that doesn’t mean that we we should delay this clean-up more than absolutely necessary. Thanks, Philipp. > On 01.02.2019, at 10:34, Philipp Tomsich > <philipp.toms...@theobroma-systems.com> wrote: > > > >> On 01.02.2019, at 10:32, Kever Yang <kever.y...@rock-chips.com >> <mailto:kever.y...@rock-chips.com>> wrote: >> >> Hi Philipp, >> >> This is not right, this patch should not merged like this!!! >> >> I have give my review comment in previous mail, and this will break >> many boards. >> >> My another patch do not break anything, but you insist NAK it >> without acceptable reason; > > What other patch? > I don’t remember seeing that one... > >> This patch definitely break other board and I have comment it, but >> you just ignore other people's review and merge it, good job! >> >> Thanks, >> - Kever >> On 02/01/2019 05:12 AM, Philipp Tomsich wrote: >>>> This function causes a 5-second delay and stops the display working on >>>> minnie. This code should be in a driver and should only be enabled by >>>> a device-tree property, so that it does not affect devices which do not >>>> have this feature. >>>> >>>> Signed-off-by: Simon Glass <s...@chromium.org> >>>> Reviewed-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> >>>> --- >>>> >>>> arch/arm/mach-rockchip/boot_mode.c | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>> Applied to u-boot-rockchip, thanks! >>> _______________________________________________ >>> U-Boot mailing list >>> U-Boot@lists.denx.de >>> https://lists.denx.de/listinfo/u-boot >> >> >> > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de> > https://lists.denx.de/listinfo/u-boot <https://lists.denx.de/listinfo/u-boot> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
