On 08/02/2019 04:14, Simon Glass wrote: > Hi Tom, > > On Mon, 21 Jan 2019 at 16:43, Simon Glass <s...@chromium.org> wrote: >> >> Hi Tom, >> >> On Mon, 21 Jan 2019 at 10:46, Tom Warren <twar...@nvidia.com> wrote: >>> >>> Let's have Jon Hunter take a look, I'll take it in to tegra/master if he >>> acks it. >> >> OK thank you. For now I've picked up the non-Tegra patches from that >> series so I can get this out. > > Any news on this? is it still pending?
I have reviewed patches 7-11 on patchwork (sorry I don't have the originals and so cannot reply inline as normal). Overall looks fine to me but a couple minor comments ... Patch 7 there is a typo in the Kconfig ... +config I2S_TEGRA + bool "Enable I2C support for Nvidia Tegra SoCs" s/I2C/I2S Patch 8, in the function 'i2s_tx_init' it should not be necessary to program the slot_ctrl register for I2S mode. Patch 8, where is 'audio_pll_clk' used? The rate looks a bit odd. For example, on the Jetson TK1 (which has the rt5677 codec), the codec operates with an MCLK of 256*fs, so at 48kHz that would be 12.288MHz. Cheers Jon -- nvpublic _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
