Dear hvaib...@ti.com, In message <1272034546-26041-6-git-send-email-hvaib...@ti.com> you wrote: > From: Vaibhav Hiremath <hvaib...@ti.com> > > This patch adds support for the EMIF4 interface > available in the AM35x processors. > > Signed-off-by: Vaibhav Hiremath <hvaib...@ti.com> > Signed-off-by: Sanjeev Premi <pr...@ti.com> > --- > arch/arm/cpu/arm_cortexa8/omap3/Makefile | 3 + > arch/arm/cpu/arm_cortexa8/omap3/emif4.c | 168 > +++++++++++++++++++++++++++ > arch/arm/include/asm/arch-omap3/cpu.h | 24 ++++ > arch/arm/include/asm/arch-omap3/emif4.h | 79 +++++++++++++ > arch/arm/include/asm/arch-omap3/sys_proto.h | 3 + > 5 files changed, 277 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/cpu/arm_cortexa8/omap3/emif4.c > create mode 100644 arch/arm/include/asm/arch-omap3/emif4.h > > diff --git a/arch/arm/cpu/arm_cortexa8/omap3/Makefile > b/arch/arm/cpu/arm_cortexa8/omap3/Makefile > index 8cc7802..0a23fa5 100644 > --- a/arch/arm/cpu/arm_cortexa8/omap3/Makefile > +++ b/arch/arm/cpu/arm_cortexa8/omap3/Makefile > @@ -36,6 +36,9 @@ COBJS += mem.o > ifdef CONFIG_SDRC > COBJS += sdrc.o > endif > +ifdef CONFIG_EMIF4 > +COBJS += emif4.o > +endif
Don't use ifdef, use COBJS-$(CONFIG_EMIF4) instead. > diff --git a/arch/arm/include/asm/arch-omap3/sys_proto.h > b/arch/arm/include/asm/arch-omap3/sys_proto.h > index 34e4e0d..7b425be 100644 > --- a/arch/arm/include/asm/arch-omap3/sys_proto.h > +++ b/arch/arm/include/asm/arch-omap3/sys_proto.h > @@ -35,6 +35,9 @@ void memif_init(void); > void sdrc_init(void); > void do_sdrc_init(u32, u32); > #endif > +#if defined(CONFIG_EMIF4) > +void emif4_init(void); > +#endif I guess you can omit the #ifdef here, right? Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A failure will not appear until a unit has passed final inspection. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
