On Saturday 15 May 2010 20:35:32 Wolfgang Denk wrote:
> --- a/mkconfig
> +++ b/mkconfig
> @@ -22,7 +22,7 @@ while [ $# -gt 0 ] ; do
> esac
> done
>
> -[ "${BOARD_NAME}" ] || BOARD_NAME="$1"
> +[ "${BOARD_NAME}" ] || BOARD_NAME="${1%%_config}"
>
> [ $# -lt 4 ] && exit 1
> [ $# -gt 6 ] && exit 1
> @@ -102,7 +102,7 @@ done
> cat << EOF >> config.h
> #define CONFIG_BOARDDIR board/$BOARDDIR
> #include <config_defaults.h>
> -#include <configs/$1.h>
> +#include <configs/${1%%_config}.h>
> #include <asm/config.h>
> EOF
it isnt harmful, but using %% when there are no glob patterns doesnt make
sense. so typically the code would be ${1%_config}. or even better, create a
new variable up front set to ${1%_config} and use that later on instead of
duplicating the same replacement construct multiple times.
-mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
