On Mon, 2019-05-06 at 21:51 -0600, Simon Glass wrote:
> Hi Matti,
>
> On Thu, 25 Apr 2019 at 03:51, Matti Vaittinen
> <matti.vaitti...@fi.rohmeurope.com> wrote:
> >
> > BD71837 and BD71847 is PMIC intended for powering single-core,
> > dual-core, and quad-core SoC’s such as NXP-i.MX 8M. BD71847
> > is used for example on NXP imx8mm EVK.
> >
> > Add regulator driver for ROHM BD71837 and BD71847 PMICs.
> > BD71837 contains 8 bucks and 7 LDOS. BD71847 is reduced
> > version containing 6 bucks and 6 LDOs. Voltages for DVS
> > bucks (1-4 on BD71837, 1 and 2 on BD71847) can be adjusted
> > when regulators are enabled. For other bucks and LDOs we may
> > have over- or undershooting if voltage is adjusted when
> > regulator is enabled. Thus this is prevented by default.
> >
> > BD718x7 has a quirk which may leave power output disabled
> > after reset if enable/disable state was controlled by SW.
> > Thus the SW control is only allowed for BD71837 bucks
> > 3 and 4 by default. The impact of this limitation must be
> > evaluated board-by board and restrictions may need to be
> > modified. (Linux driver get's these limitations from DT and we
> > may want to implement same on u-Boot driver).
> >
> > Signed-off-by: Matti Vaittinen <matti.vaitti...@fi.rohmeurope.com>
> > ---
> >
> > Changelog v2 => v3:
> > - remove unnecessary include
> > - use uint8_t instead of u8
>
> Sorry I did not reply in time. I meant that you should use uint
> instead of u8. There is no need for the arg to be 8 bits and it may
> make the machine code larger. So try to use native times for function
> args (int, uint).
Right. I'll craft a v4 then. What comes to 8bit types, which one is
preferred - u8 or uint8_t?
Br,
Matti Vaittinen
>
> Regards,
> Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
