On 25/04/19, 7:07 PM, "Tom Rini" <tr...@konsulko.com> wrote:
> On Thu, Apr 25, 2019 at 01:13:24PM +0000, Ajay Kaher wrote: > > > > Tom, [PATCH v2 1/2] reviewed by 'Matthias Brugger'. > > But no update on [Patch v2 2/2] (includes changes in include/configs/rpi.h) > > Since Matthias is the Pi custodian, I'm expecting a PR from him with the > changes. Thanks! Matthias, please let me know if you would require any info or detail from me to review [Patch v2 2/2]. To create the [Patch v2 2/2], I have taken the reference of include/configs/rockchip-common.h. Same changes are already present in include/configs/rockchip-common.h, hope this will help you to do review and PR. Thanks. - Ajay > > > > > > On 11/04/19, 10:56 AM, "akaher" <aka...@vmware.com> wrote: > > > > Fix compilation error if CONFIG_USB is disabled > > > > [Patch v2 1/2]: > > CONFIG_CMD_USB depends upon CONFIG_USB, so CONFIG_CMD_USB > > should not be enabled if CONFIG_USB is disabled. > > > > [Patch v2 2/2]: > > This patch is to fix the following compilation error when > > disabling CONFIG_USB for Rpi3: > > > > include/config_distro_bootcmd.h:242:2: error: expected ‘}’ > > before ‘BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB’ > > BOOT_TARGET_DEVICES_references_USB_without_CONFIG_CMD_USB > > > > > > Changes from v1: > > Split the patch. > > > > > > cmd/Kconfig | 1 + > > include/configs/rpi.h | 36 +++++++++++++++++++++++++++++++----- > > > > 2 file changed, 32 insertions(+), 5 deletions(-) > > > > -- > > 2.14.2 > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot