Hi Igor, On 13.05.2019 12:46, Igor Opaniuk wrote: > cpu_imx_get_temp() definition is wrapped with a ifdef macro, > therefore all function references should be also wrapped the same way > instead IS_ENABLED() usage. > > Fix warning: > arch/arm/mach-imx/imx8/cpu.c: In function ‘cpu_imx_get_desc’: > arch/arm/mach-imx/imx8/cpu.c:612:40: warning: implicit declaration of > function ‘cpu_imx_get_temp’; did you mean ‘cpu_imx_get_desc’? > [-Wimplicit-function-declaration] > ret = snprintf(buf, size, " at %dC", cpu_imx_get_temp()); > ^~~~~~~~~~~~~~~~ > cpu_imx_get_desc > cpu_imx_get_desc >
Using IS_ENABLED is typically preferred over ifdef since it assures that the code is compileable even if CONFIG_IMX_SCU_THERMAL is not enabled. I'd rather prefer we drop the the ifdef around cpu_imx_get_temp(). The linker will remove the function in case CONFIG_IMX_SCU_THERMAL is not enabled. -- Stefan > Fixes: 82467cb217 ("imx8: cpu: get temperature when print cpu desc") > Signed-off-by: Igor Opaniuk <igor.opan...@toradex.com> > --- > arch/arm/mach-imx/imx8/cpu.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-imx/imx8/cpu.c b/arch/arm/mach-imx/imx8/cpu.c > index 12596c6387..616baed7cc 100644 > --- a/arch/arm/mach-imx/imx8/cpu.c > +++ b/arch/arm/mach-imx/imx8/cpu.c > @@ -606,11 +606,11 @@ int cpu_imx_get_desc(struct udevice *dev, char > *buf, int size) > ret = snprintf(buf, size, "NXP i.MX8%s Rev%s %s at %u MHz", > plat->type, plat->rev, plat->name, plat->freq_mhz); > > - if (IS_ENABLED(CONFIG_IMX_SCU_THERMAL)) { > - buf = buf + ret; > - size = size - ret; > - ret = snprintf(buf, size, " at %dC", cpu_imx_get_temp()); > - } > +#if defined(CONFIG_IMX_SCU_THERMAL) > + buf = buf + ret; > + size = size - ret; > + ret = snprintf(buf, size, " at %dC", cpu_imx_get_temp()); > +#endif > > snprintf(buf + ret, size - ret, "\n"); _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot