Hi Simon, I will reply for the serie > Hi Patrick, > > On Mon, 20 May 2019 at 07:00, Patrick Delaunay <patrick.delau...@st.com> > wrote: > > > > > > Hi, > > > > I create this v2 serie with: > > > > 1/ documentation update for previous patch > > [U-Boot,v2] dm: remove pre reloc properties in SPL and TPL device tree > > http://patchwork.ozlabs.org/patch/1081155/ > > > > PS: Code is already merged in commit commit c7a88dae997f ("dm: remove > > pre reloc properties in SPL and TPL device tree") > > but not the documentation. > > > > 2/ missing part for (patch 1/2) > > http://patchwork.ozlabs.org/project/uboot/list/?series=89846 > > > > 3/ new tests for pre-reloc propertie in SPL as suggested by Simon > > (http://patchwork.ozlabs.org/patch/1081155/#2156621) > > > > Tell me if is better to split the serie. > > Somehow this cover letter appears in a patch, hence some of my confusion. I > see > what you are doing and it is a comprehensive approach. > > But please see my comments about comparing the .dtb file instead of making > sandbox print it out.
I will change the test to only compare the device tree : it is more simple. => v3 in few days My first approach was complicated but it is to allow - check if sandbox SPL with devicetree and libfdt in working as is already done for platdata - check if sandbox SPL can start U-Boot in booth case (by executing the simple test_000_version in ./py/tests/test_000_version.py) - split test and normal device tree (I move the "spl-tests" nodes in test.dts) But it is too complicated just the purpose of this test. NB: the executable "u-boot-spl" for sandbox_spl_defconfig already include the devicetree information, with platdata. > Regards, > Simon Regards Patrick _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot