Hi Bin, Thanks a lot for your comments!
> -----Original Message----- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: 2019年5月23日 22:23 > To: Z.q. Hou <zhiqiang....@nxp.com> > Cc: u-boot@lists.denx.de; Prabhakar Kushwaha > <prabhakar.kushw...@nxp.com>; w...@denx.de; Shengzhou Liu > <shengzhou....@nxp.com>; Jagdish Gediya <jagdish.ged...@nxp.com>; > s...@chromium.org; ley.foon....@intel.com; s...@denx.de; M.h. Lian > <minghuan.l...@nxp.com>; Xiaowei Bao <xiaowei....@nxp.com> > Subject: Re: [PATCHv2 8/8] configs: T2080QDS: Enable PCIe driver > > On Thu, May 23, 2019 at 8:22 PM Z.q. Hou <zhiqiang....@nxp.com> wrote: > > > > From: Hou Zhiqiang <zhiqiang....@nxp.com> > > > > Enable the DM PCIe driver in T2080QDS defconfig. > > > > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > > --- > > V2: > > - Enable PCIe in NAND flash, SD card and SPI flash boot defconfig. > > > > configs/T2080QDS_NAND_defconfig | 4 ++++ > > configs/T2080QDS_SDCARD_defconfig | 4 ++++ > > configs/T2080QDS_SPIFLASH_defconfig | 4 ++++ > > configs/T2080QDS_defconfig | 4 ++++ > > 4 files changed, 16 insertions(+) > > > > diff --git a/configs/T2080QDS_NAND_defconfig > > b/configs/T2080QDS_NAND_defconfig index 948a05af89..d04e223c23 > 100644 > > --- a/configs/T2080QDS_NAND_defconfig > > +++ b/configs/T2080QDS_NAND_defconfig > > @@ -38,6 +38,7 @@ > > > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kern > el),1 > > 28k(dtb),9 > > CONFIG_OF_CONTROL=y > > CONFIG_DEFAULT_DEVICE_TREE="t2080qds" > > CONFIG_ENV_IS_IN_NAND=y > > +CONFIG_DM=y > > CONFIG_FSL_CAAM=y > > CONFIG_FSL_ESDHC=y > > CONFIG_MTD_NOR_FLASH=y > > @@ -54,6 +55,9 @@ CONFIG_PHYLIB=y > > CONFIG_PHY_AQUANTIA=y > > CONFIG_E1000=y > > CONFIG_MII=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > I think we should avoid adding DM_PCI_COMPAT. Without this macro the non-DM Endpoint driver (such as e1000) won't work. > > +CONFIG_PCIE_FSL=y > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_FSL_ESPI=y > > diff --git a/configs/T2080QDS_SDCARD_defconfig > > b/configs/T2080QDS_SDCARD_defconfig > > index 30e87df3bb..7292de750b 100644 > > --- a/configs/T2080QDS_SDCARD_defconfig > > +++ b/configs/T2080QDS_SDCARD_defconfig > > @@ -38,6 +38,7 @@ > > > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kern > el),1 > > 28k(dtb),9 > > CONFIG_OF_CONTROL=y > > CONFIG_DEFAULT_DEVICE_TREE="t2080qds" > > CONFIG_ENV_IS_IN_MMC=y > > +CONFIG_DM=y > > CONFIG_FSL_CAAM=y > > CONFIG_FSL_ESDHC=y > > CONFIG_MTD_NOR_FLASH=y > > @@ -53,6 +54,9 @@ CONFIG_PHYLIB=y > > CONFIG_PHY_AQUANTIA=y > > CONFIG_E1000=y > > CONFIG_MII=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_FSL=y > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_FSL_ESPI=y > > diff --git a/configs/T2080QDS_SPIFLASH_defconfig > > b/configs/T2080QDS_SPIFLASH_defconfig > > index 0cccb3a85d..d85cc8d9d1 100644 > > --- a/configs/T2080QDS_SPIFLASH_defconfig > > +++ b/configs/T2080QDS_SPIFLASH_defconfig > > @@ -39,6 +39,7 @@ > > > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kern > el),1 > > 28k(dtb),9 > > CONFIG_OF_CONTROL=y > > CONFIG_DEFAULT_DEVICE_TREE="t2080qds" > > CONFIG_ENV_IS_IN_SPI_FLASH=y > > +CONFIG_DM=y > > CONFIG_FSL_CAAM=y > > CONFIG_FSL_ESDHC=y > > CONFIG_MTD_NOR_FLASH=y > > @@ -54,6 +55,9 @@ CONFIG_PHYLIB=y > > CONFIG_PHY_AQUANTIA=y > > CONFIG_E1000=y > > CONFIG_MII=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_FSL=y > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_FSL_ESPI=y > > diff --git a/configs/T2080QDS_defconfig b/configs/T2080QDS_defconfig > > index 79cf4424b4..df1c5183e5 100644 > > --- a/configs/T2080QDS_defconfig > > +++ b/configs/T2080QDS_defconfig > > @@ -28,6 +28,7 @@ > > > CONFIG_MTDPARTS_DEFAULT="mtdparts=fe8000000.nor:1m(uboot),5m(kern > el),1 > > 28k(dtb),9 > > CONFIG_OF_CONTROL=y > > CONFIG_DEFAULT_DEVICE_TREE="t2080qds" > > CONFIG_ENV_IS_IN_FLASH=y > > +CONFIG_DM=y > > CONFIG_FSL_CAAM=y > > CONFIG_FSL_ESDHC=y > > CONFIG_MTD_NOR_FLASH=y > > @@ -43,6 +44,9 @@ CONFIG_PHYLIB=y > > CONFIG_PHY_AQUANTIA=y > > CONFIG_E1000=y > > CONFIG_MII=y > > +CONFIG_DM_PCI=y > > +CONFIG_DM_PCI_COMPAT=y > > +CONFIG_PCIE_FSL=y > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_FSL_ESPI=y > > -- > > Regards, > Bin Thanks, Zhiqiang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot