On Thu, 30 May 2019 at 09:11, Anand Moon <linux.am...@gmail.com> wrote: > > Hi Krzysztof, > > On Wed, 29 May 2019 at 14:15, Krzysztof Kozlowski <k...@kernel.org> wrote: > > > > On Fri, 24 May 2019 at 10:51, Anand Moon <linux.am...@gmail.com> wrote: > > > > > > Fix the confict of scriptaddr address with ramdisk_addr_r used > > > in EXTRA_ENV_SETTINGS. > > > > > > Signed-off-by: Anand Moon <linux.am...@gmail.com> > > > > My comment from previous patch stays valid: > > "... but there is no conflict in the first place. These addresses are > > not used in the same time." > > > > The patch does not harm but it is not correctly explained. There is no > > issue so it is not a fix. > > > > Best regards, > > Krzysztof > > Most of the time we use custom boot.scr for loading zImage and dtb, > but some how on ARCH Linux it tried to load from this EXTRA_ENV script. > > Ok it's not a FIX, but still we need have different load address for > script (boot.scr) to loaded.
I am not that sure that you need the different address. I guess the boot.scr is loaded first and parsed/sourced entirely. Then additional commands are executed (which are already in env), so ramdisk can be loaded under the same address. However there is no problem of changing the address... just reflect it in commit message. Best regards, Krzysztof > How about change the subject and commit message to below. > > "update the scriptaddr address to load from different address used in > EXTRA_ENV_SETTINGS." > > Best Regards > -Anand _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
