On 6/4/19 5:12 AM, Dalon L Westergreen wrote: > On Tue, 2019-06-04 at 02:00 +0200, Marek Vasut wrote: >> On 6/4/19 1:57 AM, Dalon Westergreen wrote: >>> From: Dalon Westergreen < >>> dalon.westergr...@intel.com >>>> >>> >>> Some architectures, Stratix10, require a hex formatted spl that combines >>> the spl image and dtb. This adds a target to create said hex file with >>> and offset of SPL_TEXT_BASE. >>> >>> Signed-off-by: Dalon Westergreen < >>> dalon.westergr...@intel.com >>>> >>> >> >> [...] >> >>> @@ -363,6 +365,11 @@ endif >>> $(obj)/$(SPL_BIN).sfp: $(obj)/$(SPL_BIN).bin FORCE >>> $(call if_changed,mkimage) >>> >>> +OBJCOPYFLAGS_$(SPL_BIN).hex := -I binary -O ihex --change- >>> address=$(CONFIG_SPL_TEXT_BASE) >> >> Do we really need to do it here ? The commit message is not clear why >> this is needed ; I think if you link the SPl against the correct >> address, this should not be needed. >> > > This objcopy is from the binary including the dtb and not the elf. If you > objcopy using the elf, and link to the correct address, you are correct. It > is not true when just taking a binary and converting to a hex file. The > binary combined with the dtb is what is needed. > > I can try be more descriptive in the commit message. > > perhaps.. > > --- > Stratix10 requires a hex image of the spl plus spl devicetree offset to > the Stratix10 onchip memory located at SPL_TEXT_BASE. This patch adds > a target to generate a hex file from the u-boot-spl binary including the > dtb offset at SPL_TEST_BASE.
I think that's better, thanks. You could even include your explanation above. > --- > >>> +$(obj)/$(SPL_BIN).hex: $(obj)/u-boot-spl.bin FORCE >>> + $(call if_changed,objcopy) >>> + >>> quiet_cmd_mksunxiboot = MKSUNXI $@ >>> cmd_mksunxiboot = $(objtree)/tools/mksunxiboot \ >>> --default-dt $(CONFIG_DEFAULT_DEVICE_TREE) $< $@ >>> @@ -463,3 +470,4 @@ ifdef CONFIG_ARCH_K3 >>> tispl.bin: $(obj)/u-boot-spl-nodtb.bin $(SHRUNK_ARCH_DTB) $(SPL_ITS) FORCE >>> $(call if_changed,mkfitimage) >>> endif >>> + >> >> Drop this hunk > > Will do, and i likely should have used (SPL_BIN).bin rather than > u-boot-spl.bin. > > --dalon >> >> > -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
