On Thu, 6 Jun 2019 at 04:50, Samuel Mendoza-Jonas <s...@mendozajonas.com> wrote: > > Add the handling of NC-SI ethernet frames, and add a check at the start > of net_loop() to configure NC-SI before starting other network commands. > This also adds an "ncsi" command to manually start NC-SI configuration. > > Signed-off-by: Samuel Mendoza-Jonas <s...@mendozajonas.com>
We need the u-boot net specialists to weigh in, but this looks okay to me. Please clarify the help text for the NCSI command, then add: Reviewed-by: Joel Stanley <j...@jms.id.au> > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -1296,6 +1296,12 @@ config CMD_LINK_LOCAL > help > Acquire a network IP address using the link-local protocol > > +config CMD_NCSI > + bool "ncsi" > + depends on PHY_NCSI > + help > + Configure the attached NIC via NC-SI Can we clarify in the text if we need the 'ncsi' command to use any NC-SI attached NIC, or if it's more for ncsi and network debugging? _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot