On 6/22/19 9:10 PM, Simon Glass wrote:
On Sun, 2 Jun 2019 at 09:36, Heinrich Schuchardt <xypron.g...@gmx.de> wrote:

When compiling with FTRACE=1 an error

ld.bfd: disk/built-in.o: in function `lba512_muldiv':
disk/part.c:114: undefined reference to `__udivmoddi4

occurred.

Use '>> 11' instead of '/ 2048' to avoid the division.

Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
  disk/part.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

Looks OK but I think you should rename div_by to shift_right, or similar.

Thanks for reviewing.

The patch is already merged. I will send a new patch to rename the
parameter.

Regards

Heinrcih
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to