Dear "Reinhard Meyer (-VC)", In message <4c08ed38.8030...@emk-elektronik.de> you wrote: > This Patch adds support for the EMK TOP7000 CPU Module > Part 2: modified files > > Signed-off-by: Reinhard Meyer reinhard.me...@emk-elektronik.de > > > --- > MAINTAINERS | 6 ++++- > Makefile | 3 ++ > board/emk/common/vpd.c | 57 > ++++++++++++++++++++++++++++++++++++++++----
Fix your mailer, it is wrapping lines! > @@ -928,6 +928,10 @@ Haavard Skinnemoen <haavard.skinnem...@atmel.com> > ATSTK1006 AT32AP7000 > ATNGW100 AT32AP7000 > > +Reinhard Meyer <reinhard.me...@emk-elektronik.de> Please keep lists sorted - M < S > --- a/board/emk/common/vpd.c > +++ b/board/emk/common/vpd.c > @@ -1,6 +1,6 @@ > /* > - * (C) Copyright 2003 > - * Reinhard Meyer, EMK Elektronik GmbH, r.me...@emk-elektronik.de > + * (C) Copyright 2003-2010 > + * Reinhard Meyer, EMK Elektronik Please add mail address > @@ -68,12 +69,56 @@ void read_factory_r (void) > addr += p - buf; > /*printf ("%s\n", buf); */ > /* search for our specific entry */ > - if (!strncmp ((char *) buf, "[RLA/lan/Ethernet] ", 19)) { > + if (!strncmp ((char *) buf, "[RLA/lan/Ethernet] ", 19)) > setenv ("ethaddr", (char *)(buf + 19)); > - } else if (!strncmp ((char *) buf, "[BOARD/SERIAL] ", 15)) { > +#if defined(CONFIG_TOP7000) > + /* boards that have 2 LAN interfaces */ > + else if (!strncmp ((char *) buf, "[RLA/lan2/Ethernet] ", 20)) > + setenv ("eth1addr", (char *)(buf + 20)); > +#endif Curly braces are needed for multiline statements. ... > + if (eeprom_write (CONFIG_SYS_I2C_FACT_ADDR, CONFIG_SYS_FACT_OFFSET, > buf, i+2)) { > + printf ("cannot write factory configuration\n"); All previous comments apply here, too (too long lines, wrapped lines, no spaces after function name, ...) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Comparing information and knowledge is like asking whether the fatness of a pig is more or less green than the designated hitter rule." - David Guaspari _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot