On 6/24/19 7:47 PM, Adam Ford wrote: > On Mon, Jun 24, 2019 at 12:07 PM Marek Vasut <ma...@denx.de> wrote: >> >> The EHCI iMX6 driver is only partly converted to DT probing and >> still uses a tremendous amount of hard-coded addresses. Worse, >> the driver uses hard-coded SoC-model-specific base addresses, which >> are derived from values protected by SoC-specific macros, hence the >> driver is also compiled for a specific SoC model. Even worse, the >> driver depends on specific sequential indexing of the controllers, >> from which it derives offsets in the PHY and ANATOP register sets. >> >> However, when the driver is probed from DT, the indexing is not >> correct. In fact, each controller has index 0. This patch derives >> the index for DT probing case from the controller base addresses, >> which is not the way this should be done, however it is the least >> intrusive approach, favorable this close to release. >> >> The necessary steps to convert this driver fully to DT probing are >> described inside the patch, however this should be done in the next >> release and depends on iMX clock driver patches. >> >> Signed-off-by: Marek Vasut <ma...@denx.de> > > I can test this, but I am curious to know what I am supposed to see > and/if what's observable since I have been on vacation, I'm still > catching up on e-mails.
Try "usb reset", on some platforms with DM_USB enabled, every controller except for the first will either fail to init or the system will hang. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot