Le 30/05/2010 13:17, Tom Rix : > Nicolas Ferre wrote: >> For platforms that implement a hardware watchdog, call its initialization >> routine in init_sequence. >> This location has been chosen to be the closest to initialization of >> console as >> some watchdog drivers are writing status messages. On the other hand, >> watchdog >> setup should be close to chip startup to be able to begin the triggering >> quickly. >> > I am not opposed to putting watchdog into the init sequence. > > A current ARM way for initializing the watchdog is to do it in > s_init. Why doesn't this work for you ?
Well, I only see it done like this in some omap platforms. It does work for me because we do not always use the lowlevel_init.S file: sometimes, the low level initialization is done by a tiny first level bootloader... > Reviewing other watchdog additions in the init sequences from > powerpc,sh,m68k > If an init is to be added, this setup should be cut-n-pasted from one > of these. There should be follow-on patches to convert the ARM s_init's > over to using the init sequence. I guess that as architecture implementation are different in the way of initializing watchdog, I may include this in each board file or create a common initialization for AT91 at board level... Best regards, -- Nicolas Ferre _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot