> The DM_FLAG_PRE_RELOC shall be set unconditionally as this driver is going > to be re-used in both early SPL and U-Boot proper's pre-reloc. > For i.MX based devices it is crucial to have available the serial console > before relocation (otherwise the board may hand). > The device definition may be provided either via device tree description or > with U_BOOT_DEVICE(mxc_serial) definition. In the latter case the device > will not bind in U-Boot proper when DM_FLAG_PRE_RELOC is not set. > The !CONFIG_IS_ENABLED(OF_CONTROL) #if check was set as a "workaround" for > DM problem described in following commit 4687919684e0 > ("serial: Remove DM_FLAG_PRE_RELOC flag in various drivers"). > Let's look on this check more thoroughly - we add this flag if the board > doesn't support OF_CONTROL. This is a bit strange as the serial_mxc.c can > be used with CONFIG_DM_SERIAL but without corresponding device tree > description (OF_CONTROL). In such case the aforementioned > U_BOOT_DEVICE(mxc_serial) definition is used. > Other boards/SoCs have this flag set unconditionally for serial driver. > Signed-off-by: Lukasz Majewski <lu...@denx.de>
Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot