Dear Chuanhua Han, In message <20190722075642.1456-1-chuanhua....@nxp.com> you wrote: > This patch add an implementation of the rtc_enable_32khz_output() that > uses the driver model i2c APIs. > > Signed-off-by: Chuanhua Han <chuanhua....@nxp.com> > --- > drivers/rtc/ds3231.c | 17 +++++++++++++++++ > include/rtc.h | 1 + > 2 files changed, 18 insertions(+) > > diff --git a/drivers/rtc/ds3231.c b/drivers/rtc/ds3231.c > index 79b026a..2f7bbc2 100644 > --- a/drivers/rtc/ds3231.c > +++ b/drivers/rtc/ds3231.c > @@ -251,6 +251,23 @@ static int ds3231_probe(struct udevice *dev) > return 0; > } > > +void rtc_enable_32khz_output(void) > +{ > + int ret; > + struct udevice *dev; > + > +#ifdef CONFIG_DS3231_BUS_NUM > + ret = i2c_get_chip_for_busnum(CONFIG_DS3231_BUS_NUM, > + CONFIG_SYS_I2C_RTC_ADDR, 1, &dev); > +#else > + ret = i2c_get_chip_for_busnum(0, CONFIG_SYS_I2C_RTC_ADDR, 1, &dev); > +#endif > + if (!ret) > + dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR, > + RTC_STAT_BIT_BB32KHZ | > + RTC_STAT_BIT_EN32KHZ); > +} > +
You add this code unconditonally, so it increases code size for all users. But I guess only a tiny fraction will ever need this. Please add some appropiate CONFIG_ option so this code compiles only in that cases where it is really needed. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Above all else -- sky. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot