On Wed, Jul 17, 2019 at 7:41 AM Park, Aiden <aiden.p...@intel.com> wrote:
>
> Slim Bootloader provides TSC clock information in its performance
> info hob. For now, TSC clock information is only used for timer driver
> from the performance info hob.
> - Get TSC frequency from performance info hob
> - Set tsc_base and clock_rate for timer driver
So why do we need this at all? We have a common TSC driver that works
for all x86.
> +#define LOADER_PERFORMANCE_INFO_GUID \
> + { \
> + 0x868204be, 0x23d0, 0x4ff9, \
> + { 0xac, 0x34, 0xb9, 0x95, 0xac, 0x04, 0xb1, 0xb9 } \
> + }
Use EFI_GUID(), please.
> +struct performance_info {
Same, you better to make less generic names for data structs.
> +} __packed;
Same question. If it's aligned naturally by 32-bit boundaries, Why do
you need __packed?
--
With Best Regards,
Andy Shevchenko
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
