Hi Manivannan,

On 2019/7/24 下午3:59, Peter Robinson wrote:
On Mon, May 20, 2019 at 4:47 PM Manivannan Sadhasivam
<manivannan.sadhasi...@linaro.org> wrote:
This commits enables booting from eMMC when using SPL on 96Boards
Rock960 board by adding SDHCI to boot order. Since the SDHCI driver
already has the reloc flag, this works straightaway.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasi...@linaro.org>
---
  arch/arm/dts/rk3399-rock960-u-boot.dtsi | 1 +
  arch/arm/dts/rk3399-rock960.dts         | 2 ++
  2 files changed, 3 insertions(+)

diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi 
b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
index 5256f6d3f2..7fb5072a9b 100644
--- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
+++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
@@ -3,4 +3,5 @@
   * Copyright (C) 2019 Jagan Teki <ja...@amarulasolutions.com>
   */

+#include "rk3399-u-boot.dtsi"
  #include "rk3399-sdram-lpddr3-2GB-1600.dtsi"
diff --git a/arch/arm/dts/rk3399-rock960.dts b/arch/arm/dts/rk3399-rock960.dts
index 7e06bc97e5..c8b9075c73 100644
--- a/arch/arm/dts/rk3399-rock960.dts
+++ b/arch/arm/dts/rk3399-rock960.dts
@@ -12,6 +12,8 @@

         chosen {
                 stdout-path = "serial2:1500000n8";
+               u-boot,spl-boot-order = \
+                       &sdhci, &sdmmc;
Shouldn't this bit be in the rk3399-rock960-u-boot.dtsi not
rk3399-rock960.dts because it's U-Boot specific?


Peter is correct, all the update to dts by U-Boot should go to -u-boot.dtsi now,

could you update and send the patch again?


Thanks,
- Kever

         };
  };

--
2.17.1



_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to