Hi, On Wed, 31 Jul 2019 at 15:07, Joe Hershberger <joe.hershber...@ni.com> wrote: > > On Wed, Jul 31, 2019 at 3:57 PM Simon Glass <s...@chromium.org> wrote: > > > > Hi Joe, > > > > On Tue, 30 Jul 2019 at 15:35, Joe Hershberger <joe.hershber...@ni.com> > > wrote: > > > > > > On Sun, Jul 28, 2019 at 9:28 AM Simon Glass <s...@chromium.org> wrote: > > > > > > > > This typedef does not need to be defined in the search.h header since it > > > > is only used in one file (hashtable.c). Remove it from the header and > > > > change it to a struct. > > > > > > > > Signed-off-by: Simon Glass <s...@chromium.org> > > > > --- > > > > > > > > include/search.h | 2 +- > > > > lib/hashtable.c | 7 ++++--- > > > > 2 files changed, 5 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/include/search.h b/include/search.h > > > > index efa8bcbef6..c99648f80b 100644 > > > > --- a/include/search.h > > > > +++ b/include/search.h > > > > @@ -42,7 +42,7 @@ struct env_entry { > > > > > > > > /* Data type for reentrant functions. */ > > > > struct hsearch_data { > > > > - struct _ENTRY *table; > > > > + struct env_entry_node *table; > > > > > > Don't you need an opaque definition of this? > > > > I don't see why. We can just use struct env_entry_node which is opaque > > if the definition is not available. > > I agree, but doesn't it need to be defined? Maybe the misunderstanding > is happening because of the intermediate state of things through out > this series.
(yes, I had trouble figuring out how to split this series up so people could actually review it!) I don't think it needs to be defined separate here, since it is not in a function scope, so mentioning it inside a struct seems to work OK. > > > > > > > > > Also, there is an opaque definition of _ENTRY in this file that needs > > > to go away. > > > > Where is that? I can't see it. > > I'm looking at master... "include/search.h" line 42 of 123 OK, I see. That is removed in the previous patch "env: Drop the ENTRY typdef" Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot