On Fri, Aug 16, 2019 at 01:59:20PM +0300, Sam Protsenko wrote: [..] > On Fri, Aug 16, 2019 at 1:36 PM Eugeniu Rosca <ero...@de.adit-jv.com> wrote: > > Thanks for the efforts. I get the same result, except the following > > minor difference [*]. The diff is minor and non-functional, but I > > think it's worth staying closer to AOSP. > > I've used most recent commit on master branch of external/avb project > of AOSP, and I can see that avb_div_by_10() is sitting in the end of > file: [1]. Not sure why you have different result... Are you looking > to different branch/commit perhaps? > > [1] > https://android.googlesource.com/platform/external/avb/+/5fbb42a189aabb9a0bb5c3a8df89c9baf828a0d1/libavb/avb_sysdeps_posix.c#84
Small amendment. Since I effectively cherry picked the AOSP commits from AVB into U-Boot (as described in [2]), my result left the avb_div_by_10() function *in place* (as none of the imported AOSP commits does any change to this function). That led to the mismatch between our results. IOW what this patch appears to do *in addition* to importing the list of AOSP commits mentioned in [2] is repositioning the avb_div_by_10() such that it matches the AOSP. I obviously have no concerns about that. [2] https://patchwork.ozlabs.org/patch/1144801/#2235834 Having said that: Reviewed-by: Eugeniu Rosca <rosca.euge...@gmail.com> Thanks! -- Best Regards, Eugeniu. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
