> -----Original Message----- > From: Alex Marginean <alexm.ossl...@gmail.com> > Sent: Friday, July 12, 2019 5:17 PM > To: Chuanhua Han <chuanhua....@nxp.com>; albert.u.b...@aribaud.net; > Sudhanshu Gupta <sudhanshu.gu...@nxp.com>; Harninder Rai > <harninder....@nxp.com>; Rajesh Bhagat <rajesh.bha...@nxp.com>; Andy > Tang <andy.t...@nxp.com>; Prabhakar Kushwaha > <prabhakar.kushw...@nxp.com> > Cc: u-boot@lists.denx.de > Subject: Re: [U-Boot] [PATCH v4 1/4] armv8: ls1028a: The ls1028a platform > supports the I2C driver model > > On 7/10/2019 4:16 PM, Chuanhua Han wrote: > > DM_I2C_COMPAT is a compatibility layer that allows using the non-DM > > I2C API when DM_I2C is used.When DM_I2C_COMPAT is not enabled for > > compilation, a compilation error will be generated. This patch solves > > the problem that the i2c-related api of the ls1028a platform does not > > support dm. > > I wouldn't mention DM_I2C_COMPAT at all in the commit message, it's not > currently enabled and after this patch set it's not needed either. > You could just mention that the patch is updating ls1028a board init code to > support DM_I2C. > > > > > Signed-off-by: Chuanhua Han <chuanhua....@nxp.com> > > --- > > depends on: > > - > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D113364& > data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b7844837 > 72d08d706bea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636 > 985288233302816&sdata=Fca4rUVC9A%2BemvycTWnILNfGvlg42iOlwozk > c0ngIwM%3D&reserved=0 > > - > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatch > work.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D110856& > data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b7844837 > 72d08d706bea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636 > 985288233302816&sdata=9%2F1FmA0GZqnODbYvuX3SERC8TDcYF8eMX > mLzILb3wH0%3D&reserved=0 > > - > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc > > > hwork.ozlabs.org%2Fproject%2Fuboot%2Flist%2F%3Fseries%3D109677& > ;dat > > > a=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7C6f4831088b784483772d > 08d706b > > > ea74c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369852882333 > 02816& > > > amp;sdata=HYgFDC9knJz3HdY5BLAHwotg5OutAWWEbz6xmm%2FTXzs%3D& > amp;reserve > > d=0 > > > > Changes in v4: > > - No change. > > Changes in v3: > > - No change. > > Changes in v2: > > - No change. > > > > arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 8 -------- > > board/freescale/ls1028a/ls1028a.c | 8 ++++++++ > > include/configs/ls1028a_common.h | 3 --- > > include/configs/ls1028ardb.h | 1 - > > 4 files changed, 8 insertions(+), 12 deletions(-) > > > > code changes look OK to me. > > Reviewed-by: Alex Marginean <alexm.ossl...@gmail.com>
This patch has been applied to fsl-qoriq master, awaiting upstream. --pk _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot