Dear Chuanhua Han,
In message <20190726112403.32842-1-chuanhua....@nxp.com> you wrote:
> This patch add an implementation of the rtc_enable_32khz_output() that
> uses the driver model i2c APIs.
...
> + ret = i2c_get_chip_for_busnum(busnum, chip_addr, 1, &dev);
> + if (!ret)
> + ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
> + RTC_STAT_BIT_BB32KHZ |
> + RTC_STAT_BIT_EN32KHZ);
Strictly speaking, this is a multi-line statement following the "if"
so braces are required according to the coding style:
if (!ret) {
ret = dm_i2c_reg_write(dev, RTC_STAT_REG_ADDR,
RTC_STAT_BIT_BB32KHZ |
RTC_STAT_BIT_EN32KHZ);
}
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
What can it profit a man to gain the whole world and to come to his
property with a gastric ulcer, a blown prostate, and bifocals?
-- John Steinbeck, _Cannery Row_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
