On Wed, 2019-08-28 at 15:18 +0200, Stefan Roese wrote: > On 28.08.19 08:37, Weijie Gao wrote: > > This patch updates reset controller node for mt7628 > > > > Signed-off-by: Weijie Gao <weijie....@mediatek.com> > > --- > > arch/mips/dts/mt7628a.dtsi | 36 ++++++++++++++++++++++++------------ > > 1 file changed, 24 insertions(+), 12 deletions(-) > > > > diff --git a/arch/mips/dts/mt7628a.dtsi b/arch/mips/dts/mt7628a.dtsi > > index f07de1b611..0e2b6598ea 100644 > > --- a/arch/mips/dts/mt7628a.dtsi > > +++ b/arch/mips/dts/mt7628a.dtsi > > @@ -1,4 +1,5 @@ > > // SPDX-License-Identifier: GPL-2.0 > > +#include <dt-bindings/reset/mt7628-reset.h> > > > > / { > > #address-cells = <1>; > > @@ -16,11 +17,6 @@ > > }; > > }; > > > > - resetc: reset-controller { > > - compatible = "ralink,rt2880-reset"; > > - #reset-cells = <1>; > > - }; > > - > > cpuintc: interrupt-controller { > > #address-cells = <0>; > > #interrupt-cells = <1>; > > @@ -48,6 +44,12 @@ > > mask = <0x1>; > > }; > > > > + rstctrl: rstctrl@0x34 { > > + reg = <0x34 0x4>; > > + compatible = "mediatek,mtmips-reset"; > > + #reset-cells = <1>; > > + }; > > + > > pinctrl: pinctrl@60 { > > compatible = "mediatek,mt7628-pinctrl"; > > reg = <0x3c 0x2c>, <0x1300 0x100>; > > @@ -202,7 +204,7 @@ > > compatible = "ralink,mt7628a-wdt", > > "mediatek,mt7621-wdt"; > > reg = <0x100 0x30>; > > > > - resets = <&resetc 8>; > > + resets = <&rstctrl MT7628_TIMER_RST>; > > I like this patch. But we should always keep in mind to stay in sync (or sync > in the future) with the Linux DT sources. And in Linux currently, its the > "old" > syntax that you are removing with this patch. > > Do you plan to update the Linux DT as well, so that the bindings match again? > > Thanks, > Stefan
I agree with that. At lease a reset controller won't make things complex. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot