>On Wed, Sep 4, 2019 at 11:37 PM Eugeniy Paltsev ><eugeniy.palt...@synopsys.com> wrote: >> >> Commit c4e8862308d4 (mtd: spi: Switch to new SPI NOR framework) >> performs switch from previous 'spi_flash' infrastructure without >> proper testing/investigations which results in regressions. >> >> Fix regression related to SST26 flash IC series which is lacking >> protection ops implementation which were introduced previously by >> Commit 3d4fed87a5fa (mtd: sf: Add support of sst26wf* flash ICs >> protection ops) >> >> Signed-off-by: Eugeniy Paltsev <eugeniy.palt...@synopsys.com> >> --- >> Tom, could you please pick this patch to 2019.10? >> [snip] >> + { INFO("sst26wf032", 0xbf2622, 0, 64 * 1024, 64, SECT_4K | >> SPI_NOR_HAS_SST26LOCK) }, >> + { INFO("sst26wf064", 0xbf2643, 0, 64 * 1024, 128, SECT_4K | >> SPI_NOR_HAS_SST26LOCK) }, > >Thought the commit message says it is revert, the patch contents seems >adding new changes.
Revert of removing functionality is adding functionality, isn't it? ;) > So, better add them by saying missing >functionalities. If possible please break the patches into multiple >patches. Ok, I'll split this patch for adding SST26 protection ops part and applying this ops to corresponding flash ICs. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot