On Thu, 2010-06-24 at 18:37 +0200, Mike Frysinger wrote:
> On Thursday, June 24, 2010 05:31:47 Tor Krill wrote:
> >  void reset_phy(void)
> >  {
> >     char *name = "egiga0";
> > +   u8 port_addr[] = CONFIG_PHY_ADDRS;
> > 
> >     if (miiphy_set_current_dev(name))
> >             return;
> > 
> >     /* reset the phy */
> > -   miiphy_reset(name, CONFIG_PHY_BASE_ADR);
> > +   miiphy_reset(name, port_addr[0]);
> >  }
> 
> hmm, this cant possibly be correct.  how do you know which of the phys is to 
> be reset ?  but i guess that's just a bug in the ARM tree you cant do much 
> about without fixing everyone.

In the original the base adress was used to adress the PHY being reset
and as long as you don't enter the addresses in reverse in the array the
above construction should work. (And since this is for a specific board,
only using one PHY(?), it should be quite isolated.)

/Tor

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to