On Fri, Sep 13, 2019 at 5:10 PM Tom Rini <tr...@konsulko.com> wrote: > > On Wed, Sep 11, 2019 at 03:39:53PM +0200, Michal Simek wrote: > > > From: T Karthik Reddy <t.karthik.re...@xilinx.com> > > > > This patch uses auto instead of decimal in simple_strtoul(). > > > > Signed-off-by: T Karthik Reddy <t.karthik.re...@xilinx.com> > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> > > --- > > > > cmd/test.c | 24 ++++++++++++------------ > > 1 file changed, 12 insertions(+), 12 deletions(-) > > > > diff --git a/cmd/test.c b/cmd/test.c > > index fa0c349f0827..258bfd880653 100644 > > --- a/cmd/test.c > > +++ b/cmd/test.c > > @@ -113,28 +113,28 @@ static int do_test(cmd_tbl_t *cmdtp, int flag, int > > argc, char * const argv[]) > > expr = strcmp(ap[0], ap[2]) > 0; > > break; > > case OP_INT_EQ: > > - expr = simple_strtol(ap[0], NULL, 10) == > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) == > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_INT_NEQ: > > - expr = simple_strtol(ap[0], NULL, 10) != > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) != > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_INT_LT: > > - expr = simple_strtol(ap[0], NULL, 10) < > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) < > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_INT_LE: > > - expr = simple_strtol(ap[0], NULL, 10) <= > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) <= > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_INT_GT: > > - expr = simple_strtol(ap[0], NULL, 10) > > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) > > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_INT_GE: > > - expr = simple_strtol(ap[0], NULL, 10) >= > > - simple_strtol(ap[2], NULL, 10); > > + expr = simple_strtol(ap[0], NULL, 0) >= > > + simple_strtol(ap[2], NULL, 0); > > break; > > case OP_FILE_EXISTS: > > expr = file_exists(ap[1], ap[2], ap[3], FS_TYPE_ANY); > > I'm going to NAK this, but could be argued around to changing my mind. > While it's true that in general command inputs are hex and not decimal, > this has been decimal since introduction in 2009. So changing it now is > breaking ABI and other peoples test scripts, so I don't think we can do > this, sorry.
Well, I think that this is automatic. There should be a back compatibility with the ABI if base is 10 Michael > > -- > Tom > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
