Hi Simon, > Hi Lukasz, > > On Tue, 17 Sep 2019 at 00:22, Lukasz Majewski <lu...@denx.de> wrote: > > > > Hi Simon, > > > > > On Sun, 18 Aug 2019 at 19:30, Peng Fan <peng....@nxp.com> wrote: > > > > > > > > > Subject: [PATCH v2 8/9] spl: Introduce SPL_DM_GPIO Kconfig > > > > > define > > > > > > > > > > This define indicates if DM_GPIO shall be supported in SPL. > > > > > This allows proper operation of DM converted GPIO drivers in > > > > > SPL, which use #if !CONFIG_IS_ENABLED(DM_GPIO) to also > > > > > support not yet DM/DTS converted boards. > > > > > > > > > > Signed-off-by: Lukasz Majewski <lu...@denx.de> > > > > > --- > > > > > > > > > > Changes in v2: > > > > > - New patch > > > > > > > > > > common/spl/Kconfig | 6 ++++++ > > > > > 1 file changed, 6 insertions(+) > > > > > > > > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > > > > > But how about adding && DM_GPIO as well to that depends clause? > > > > I think that they shall be a separate Kconfig options. Please > > imagine that one have board with SPL GPIO support, but not in > > U-Boot proper. > > Do we really want to support that? It seems a bit odd to me. > > Most of the DM SPL configs assume/requiree you have U-Boot proper > enabled.
After some thoughts - I think that we shall add the dependency on DM_GPIO (the SPL_DM_GPIO shall be only visible when DM_GPIO is defined). > > Regards, > Simon Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lu...@denx.de
pgpwJBvBN2x7j.pgp
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot