> > On Thu, 2010-07-01 at 09:45 -0500, Paulraj, Sandeep wrote: > > > > > > > > On Wed, 2010-06-30 at 14:38 -0500, Paulraj, Sandeep wrote: > > > > > > > > > > > > > > This is version 4, which takes into account all feedback to date, > and > > > has > > > > > been rebased on the next branch. > > > > > > > > > > The folowing series adds support for two boards based upon the TI > > > > > OMAP4430. The OMAP4430 is a Cortex-A9 based SOC from TI. > > > <snip> > > > > > > > > I ran MAKEALL for ARMV7 and I got several compile errors. > > > > > > > > I have setup a testing branch for you(u-boot-ti/testing) with all > the > > > patches applied. > > > > > > > > Please fix and resubmit. > > > > > > I'm not quite sure what went awry here, but the compile errors are > > > caused by the fix you did to the mmc patch. Perhaps due to applying > the > > > patches out of order in your testing branch?? > > > > > > In any event, the patches seem to work here applied to the current > > > master/next in the original order. > > > > > > Here's a pointer to my working git branch: > > > > > > http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u- > > > boot.git;a=shortlog;h=refs/heads/omap4-next-upstream > > > > > > I added your "Signed-off-by" in case you wanted to just do a pull. > But > > > I am also happy to resubmit the patches if you prefer that. > > > > > > Regards, > > > > > > Steve > > > > > > > This is what I get. I think the recent changes in Makefile are also > resulting in 2 of these. > > Yes, I don't think that the 2 errors are related to my patches > (am3517_evm_config and s5p_goni_config). Neither of those boards seem > to have made it into boards.cfg
That seems to be the reason > > Is this something that you want me to submit a fix patch for, or are > those board maintainers going to handle this? If you have time then it would be nice to get a patch with the entries in boards.cfg > > The two warnings are also not caused by my patch, that issue has always > been there for any board that defines CMD_MMC and > CONFIG_SYS_MMC_SET_DEV. Granted, no boards up to now make use of that > feature :-) > > I think the solution is simply to add a prototype for the mmc_set_dev > function to mmc.h > > I can do this as a separate fixit patch unrelated to my series, or I can > add it to the "OMAP: mmc: add support for second and third mmc channels" > and resubmit the patch series. The latter might make sense since my two > boards are the first to actually make use of the CONFIG_SYS_MMC_SET_DEV > functionality. > > Which would you prefer? Just submit a new patch to get rid of the compile issues. No need to resubmit the original patch or the series. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot