On Sun, 2019-10-13 at 18:55 +0800, Matthias Brugger wrote:
> 
> On 11/09/2019 13:14, mingming lee wrote:
> > Add support for MediaTek MT8518 SoC. This include the file
> > that will initialize the SoC after boot and its device tree.
> > 
> > Signed-off-by: mingming lee <mingming....@mediatek.com>
> > ---
> >  arch/arm/dts/mt8518.dtsi                      | 201 ++++++++++++++++++
> >  arch/arm/mach-mediatek/Kconfig                |   9 +
> >  arch/arm/mach-mediatek/Makefile               |   1 +
> >  arch/arm/mach-mediatek/mt8518/Makefile        |   4 +
> >  arch/arm/mach-mediatek/mt8518/init.c          | 116 ++++++++++
> >  arch/arm/mach-mediatek/mt8518/lowlevel_init.S |  59 +++++
> >  6 files changed, 390 insertions(+)
> >  create mode 100644 arch/arm/dts/mt8518.dtsi
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/Makefile
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/init.c
> >  create mode 100644 arch/arm/mach-mediatek/mt8518/lowlevel_init.S
> > 
> > diff --git a/arch/arm/dts/mt8518.dtsi b/arch/arm/dts/mt8518.dtsi
> > new file mode 100644
> > index 0000000000..39d001884f
> > --- /dev/null
> > +++ b/arch/arm/dts/mt8518.dtsi
> > @@ -0,0 +1,201 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +/*
> > + * Copyright (C) 2019 MediaTek Inc.
> > + * Author: Mingming Lee <mingming....@mediatek.com>
> > + *
> > + */
> > +
> > +#include <dt-bindings/clock/mt8518-clk.h>
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +/ {
> > +   compatible = "mediatek,mt8518";
> > +   interrupt-parent = <&sysirq>;
> > +   #address-cells = <1>;
> > +   #size-cells = <1>;
> > +
> > +   cpus {
> > +           #address-cells = <1>;
> > +           #size-cells = <0>;
> > +           enable-method = "mediatek,mt8518-smp";
> > +
> > +           cpu0: cpu@0 {
> > +                   device_type = "cpu";
> > +                   compatible = "arm,cortex-a53";
> > +                   reg = <0x0>;
> > +                   clock-frequency = <1300000000>;
> > +           };
> > +
> > +           cpu1: cpu@1 {
> > +                   device_type = "cpu";
> > +                   compatible = "arm,cortex-a53";
> > +                   reg = <0x1>;
> > +                   clock-frequency = <1300000000>;
> > +           };
> > +
> > +           cpu2: cpu@2 {
> > +                   device_type = "cpu";
> > +                   compatible = "arm,cortex-a53";
> > +                   reg = <0x2>;
> > +                   clock-frequency = <1300000000>;
> > +           };
> > +
> > +           cpu3: cpu@3 {
> > +                   device_type = "cpu";
> > +                   compatible = "arm,cortex-a53";
> > +                   reg = <0x3>;
> > +                   clock-frequency = <1300000000>;
> > +           };
> > +   };
> > +
> > +   chipid: chipid@08000000 {
> > +           compatible = "mediatek,chipid";
> > +           reg = <0x08000000 0x0004>,
> > +                 <0x08000004 0x0004>,
> > +                 <0x08000008 0x0004>,
> > +                 <0x0800000c 0x0004>;
> > +   };
> 
> I couldn't find any driver using this compatible.
> You may want to drop this 'device'.
> 
> Regards,
> Matthias

Thank you for review.
I will drop this 'device' and also drop other unused 'device'.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to