Hi Kever, On Fri, Oct 18, 2019 at 4:26 PM Kever Yang <kever.y...@rock-chips.com> wrote: > > Jagan, > > > On 2019/10/18 上午3:07, Jagan Teki wrote: > > idbloader.img name is specific to rockchip, > > This is specific for rockchip, like rksd, rkspi type in mkimage, since > it's clear for what it stands for, > > I think it can also used in U-Boot. > > > where it usually > > created using rockchip tools. > > > No, idbloader stands for the image with idb header packaged with two > stage loader, eg. TPL+SPL > > or ddr.bin+miniloader.bin, and maybe ddr.bin + SPL， TPL+miniloader.bin, > > not related to rockchip tools, it can also be created with U-Boot > mkimage tool.
I understand what idbloader contains, it is like rockchip SPL. but the main concern here is the naming convention used in U-Boot. It would be a standard way of using naming conventions where the final output naming conventions should have u-boot support stages(TPL, SPL, U-Boot) and platform specific name. This way it is less confused what exactly it contains. Moreover most of the platform specific bin ended up using this type of conventions. - u-boot-spl-mtk.bin - Mediatek SPL bin - u-boot-mtk.bin - Mediatek U-Boot bin (would be final image) - u-boot-sunxi-with-spl.bin - Allwinner U-Boot with SPL - u-boot-x86-start16-tpl.bin Similar naming conventions used for tegra, x86 etc. I'm completely aware of what you're trying to abbreviate idbloader.img, but having u-boot-spl-rockchip.bin is more readable and understand than idbloader. > > > Since the image is created as > > per U-Boot generic builds like SPL, better to follow the > > generic U-Boot naming notation like other SoC's following. > > > > Enable idbloader.img with u-boot-spl-rockchip.bin and create > > the same in spl directory since it is SPL file and Makefile.spl > > will clean it by default. > > > > Cc: Kever Yang <kever.y...@rock-chips.com> > > Cc: Matwey V. Kornilov <matwey.korni...@gmail.com> > > Signed-off-by: Jagan Teki <ja...@amarulasolutions.com> > > --- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index ec55e0f6a4..918b5d53e0 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -887,7 +887,7 @@ ALL-y += u-boot-with-dtb.bin > > endif > > > > ifeq ($(CONFIG_ARCH_ROCKCHIP)$(CONFIG_SPL)$(CONFIG_TPL),yyy) > > -ALL-y += idbloader.img > > +ALL-y += spl/u-boot-spl-rockchip.bin > > > This idbloader including IDB header, TPL, and SPL, I don't think name it > as spl and > > put it in spl directory make any sense. > > I though the origin output file use postfix '.bin' and those image after > pack and can be > > dd to storage directly better to use postfix '.img'. > > About the clean, it will be better to be clean like other '.img' file in > the Makefile. This make sense, I have next version set where it used handle these so carefully. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
